This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/7] Don't check abbrev is NULL in read_partial_die

From: Simon Marchi <simark at simark dot ca>
To: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
Date: Sun, 25 Feb 2018 18:33:48 -0500
Subject: Re: [PATCH 2/7] Don't check abbrev is NULL in read_partial_die
Authentication-results: sourceware.org; auth=none
References: <1519313796-2397-1-git-send-email-yao.qi@linaro.org> <1519313796-2397-3-git-send-email-yao.qi@linaro.org>

On 2018-02-22 10:36 AM, Yao Qi wrote:
> 'abbrev' won't be NULL, so don't check it.
> 
> gdb:

I would suggest changing abbrev type to a const reference then.

Simon

References:
- [PATCH 0/7 v2] Class-fy partial_die_info
  - From: Yao Qi
- [PATCH 2/7] Don't check abbrev is NULL in read_partial_die
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]