This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 1/3] Initial support for variant parts

From: Tom Tromey <tom at tromey dot com>
To: Tom Tromey <tom at tromey dot com>
Cc: Joel Brobecker <brobecker at adacore dot com>, gdb-patches at sourceware dot org
Date: Wed, 21 Feb 2018 10:34:14 -0700
Subject: Re: [RFA 1/3] Initial support for variant parts
Authentication-results: sourceware.org; auth=none
References: <20180220190613.24148-1-tom@tromey.com> <20180220190613.24148-2-tom@tromey.com> <20180221050300.acdpde2o7qayaud7@adacore.com> <87o9kiqr1x.fsf@tromey.com>

>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:

Tom> It seems to me that using a wide-enough scalar here would be enough for
Tom> all the cases you list, provided that sign extension was handled
Tom> properly.  I'm not 100% sure this does handle sign extension though -- I
Tom> can update the test for that.

I did this, and I think my patch is ok here -- but this revealed a
latent bug in unpack_bits_as_long.  That function was not doing sign
extension in the case where the field was not a bitfield.  This seems
incorrect to me, so I will add another patch to my series to fix this.

Tom

References:
- [RFA 0/3] Discriminated unions
  - From: Tom Tromey
- [RFA 1/3] Initial support for variant parts
  - From: Tom Tromey
- Re: [RFA 1/3] Initial support for variant parts
  - From: Joel Brobecker
- Re: [RFA 1/3] Initial support for variant parts
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]