Re: [PATCH v3 4/4] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p

[Eli Zaretskii <eliz at gnu dot org>]

> Date: Wed, 20 Dec 2017 07:13:00 +0900
> From: Stafford Horne <shorne@gmail.com>
> Cc: gdb-patches@sourceware.org, openrisc@lists.librecores.org
> 
> > >  @item group
> > > -The register group to which this register belongs.  It must
> > > -be either @code{general}, @code{float}, or @code{vector}.  If no
> > > -@var{group} is specified, @value{GDBN} will not display the register
> > > -in @code{info registers}.
> > > +The register group to which this register belongs.  It can be one of the
> > > +standard register groups @code{general}, @code{float}, @code{vector} or an
> > > +arbitrary string.  The string should be limited to alphanumeric characters
> > > +and internal hyphens.  If no @var{group} is specified, @value{GDBN} will
> > 
> > What do you mean by "internal hyphens"?
> 
> This means, hyphens withing the register group name, not starting or ending with
> hyphens.  (i.e. special-spr,  but not rg1- or -rg2)

Then I think this text needs to be rephrased, so that it first says
what are the characters allowed in a reggroup name, and then says that
ranges of groups, with 2 group names separated by hyphens, are also
accepted.

Thanks.