This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v6 2/2] Implement pahole-like 'ptype /o' option
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Tom Tromey <tom at tromey dot com>, Eli Zaretskii <eliz at gnu dot org>, Simon Marchi <simon dot marchi at ericsson dot com>, Keith Seitz <keiths at redhat dot com>
- Date: Thu, 14 Dec 2017 15:31:39 -0500
- Subject: Re: [PATCH v6 2/2] Implement pahole-like 'ptype /o' option
- Authentication-results: sourceware.org; auth=none
- References: <20171121160709.23248-1-sergiodj@redhat.com> <20171214024816.29629-1-sergiodj@redhat.com> <20171214024816.29629-3-sergiodj@redhat.com> <1db3626e-95b3-45b2-2e2e-dc27e97dda16@redhat.com>
On Thursday, December 14 2017, Pedro Alves wrote:
> Something broke in v5 -> v6 in the offset and hole computation.
Thanks for catching this.
Indeed, the way the offset_bitpos is propagated has changed, and the
patch is wrongly calculating it before printing inner fields of
structs/unions.
I've fixed the logic and now the behavious is back to the old one. All
the tests that were passing before are still passing now, which means
that I wasn't testing this specific scenario. For that reason, I've
added one more test to cover this.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/