Re: [PATCH 3/5] Don't ever Quit out of resume

[Pedro Alves <palves at redhat dot com>]

On 12/09/2017 01:16 AM, Maciej W. Rozycki wrote:
> Hi Pedro,
> 
> On Mon, 6 Nov 2017, Pedro Alves wrote:
> 
>> gdb/ChangeLog:
>> yyyy-mm-dd  Pedro Alves  <palves@redhat.com>
>>
>> 	* infrun.c (resume_cleanups): Delete.
>> 	(resume): No longer install a resume_cleanups cleanup nor call
>> 	QUIT.
>> 	(proceed): Pass the terminal to the inferior.
>> 	(keep_going_pass_signal): No longer install a resume_cleanups
>> 	cleanup.
> 
>  This change, i.e.:
> 
> commit d930703d68ae160ddfe8ebe5fdcf416fb6090e1e
> Author: Pedro Alves <palves@redhat.com>
> Date:   Thu Nov 16 18:44:43 2017 +0000
> 
> caused regressions to appear in remote `mips-mti-linux-gnu' target testing 
> (`x86_64-linux-gnu' host), specifically:
> 
> FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind
> FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw on: single-step breakpoint is not left behind
> FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw off: step in ro region (cannot insert hw break)
> FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw off: single-step breakpoint is not left behind
> FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw on: single-step breakpoint is not left behind
> 
> and indeed detailed logs indicate a breakpoint is left lingering, e.g.:
> 
> (gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: step in ro region (cannot insert sw break)
> maint info breakpoints 0
> Num     Type           Disp Enb Address    What
> 0       sw single-step keep y   0x00400774 in main at [...]/gdb/testsuite/gdb.base/breakpoint-in-ro-region.c:24 inf 1 thread 1
> 	stop only in thread 1
> (gdb) FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind
> 
> vs:
> 
> (gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: step in ro region (cannot insert sw break)
> maint info breakpoints 0
> No breakpoint or watchpoint matching '0'.
> (gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind
> 
> as at commit d930703d68ae^.
> 
>  Can you please look into it?  If I can assist you anyhow, then just let 
> me know.
> 

Thanks.  I filed <https://sourceware.org/bugzilla/show_bug.cgi?id=22583> to
track this.

Pedro Alves