Re: [RFA] Adjust gdb.arch/i386-sse-stack-align.exp print statement

[Pedro Alves <palves at redhat dot com>]

On 12/07/2017 11:30 PM, Sergio Durigan Junior wrote:
> 
> commit 46a4882b3c7d9ec981568b8b13a3c9c39c8f8e61
> Author: Pedro Alves <palves@redhat.com>
> Date:   Mon Sep 4 20:21:15 2017 +0100
> 
>     Stop assuming no-debug-info variables have type int
> 
> We now have to explicitly tell GDB the type of the non-debug-info
> variable we want to print (by casting).  This commit adjusts the
> "print" statement on gdb.arch/i386-sse-stack-align.exp to do the
> proper cast, fixing a failure that started to happen after the
> mentioned commit.
> 
> gdb/testsuite/ChangeLog:
> 2017-12-07  Sergio Durigan Junior  <sergiodj@redhat.com>
> 
> 	* gdb.arch/i386-sse-stack-align.exp: Cast "print" variable to
> 	"int".

This is OK, except...

> ---
>  gdb/testsuite/ChangeLog                         | 5 +++++
>  gdb/testsuite/gdb.arch/i386-sse-stack-align.exp | 2 +-
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
> index 53f114aa15..81d23d1bb1 100644
> --- a/gdb/testsuite/ChangeLog
> +++ b/gdb/testsuite/ChangeLog
> @@ -1,3 +1,8 @@
> +2017-12-07  Sergio Durigan Junior  <sergiodj@redhat.com>
> +
> +	* gdb.arch/i386-sse-stack-align.exp: Cast "print" variable to
> +	"int".
> +
>  2017-12-07  Keith Seitz  <keiths@redhat.com>
>  
>  	* gdb.cp/nested-types.cc: New file.
> diff --git a/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp b/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp
> index 47fb9f42d2..946f217ce1 100644
> --- a/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp
> +++ b/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp
> @@ -43,7 +43,7 @@ if ![runto_main] then {
>  
>  set args ""
>  foreach i {0 1 2 3 4} {
> -    set test "print g$i ($args)"
> +    set test "print (int) g$i ($args)"

... this is printing/calling a function, not a variable:

 (gdb) print g0 ()
 'g0' has unknown return type; cast the call to its declared return type

So the git log and ChangeLog are inaccurate and should
reference 7022349d5c86 ("Stop assuming no-debug-info functions
return int") instead.

OK with that fixed.

Thanks,
Pedro Alves