In your quote, there appears to be two added lines (two +):
> - = (const char *) xml_find_attribute (attributes, "version")->value;
> + = (const char *) xml_find_attribute (attributes,
> + "version")->value.get ();
But in my patch it's all on the same line. I am confused.
That's what I meant with odd. Looks like some extra line breaks.
> @@ -2040,8 +2042,8 @@ parse_xml_btrace_block (struct gdb_xml_parser
*parser,
> gdb_xml_error (parser, _("Btrace format error."));
> }
>
> - begin = (ULONGEST *) xml_find_attribute (attributes,
> "begin")->value;
> - end = (ULONGEST *) xml_find_attribute (attributes, "end")->value;
> + begin = (ULONGEST *) xml_find_attribute (attributes,
> + "begin")->value.get (); end = (ULONGEST *) xml_find_attribute
> + (attributes, "end")->value.get ();
And here, the line break after ';' seems to have been removed.