This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Initialize target description early in IPA
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Date: Thu, 7 Dec 2017 11:30:09 +0000
- Subject: Re: [PATCH] Initialize target description early in IPA
- Authentication-results: sourceware.org; auth=none
- References: <1512640910-26090-1-git-send-email-yao.qi@linaro.org>
Hi Yao,
Thanks for the fix. This is OK. A couple minor nits below.
On 12/07/2017 10:01 AM, Yao Qi wrote:
> +#if !defined __ILP32__
> +/* Map the tdesc index to xcr0 mask. */
> +uint64_t idx2mask[X86_TDESC_LAST] = {
"static" ?
> +/* Map the tdesc index to xcr0 mask. */
> +uint64_t idx2mask[X86_TDESC_LAST] = {
"static" ?
> + global decimal
> + set test "advance through tracing"
> + gdb_test_multiple "continue" $test {
> + -re "Thread 2 .* hit Catchpoint $decimal \\(call to syscall .*\\).*\r\n$gdb_prompt $" {
> + # IPA starts a helper thread, which calls accept. Ignore it.
> + send_gdb "continue\n"
> + exp_continue
> + }
(Bah, it's unfortunate that we don't have syntax to make
catchpoints be thread specific... )
> + -re "Breakpoint \[0-9\]+, end .*$gdb_prompt $" {
You could use $decimal here too.
> + pass $test
> + }
> + }
>
> gdb_test "tstatus" ".*Trace .*" "check on trace status"
Thanks,
Pedro Alves