This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix regression in "commands"
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 4 Dec 2017 15:55:17 +0000
- Subject: Re: [RFA] Fix regression in "commands"
- Authentication-results: sourceware.org; auth=none
- References: <20171103190747.389-1-tom@tromey.com> <3a860acf-6e64-b2ba-e3fd-560406077259@redhat.com> <87r2se5qv0.fsf@tromey.com>
On 12/01/2017 04:56 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> I wonder whether gdb.base/commands.exp is a better home for this.
>
> That file has some tests of "commands" but also is a grab-bag of testing
> random commands. I don't think the name specifically has to do with the
> "commands" command; so unless you feel strongly about it, I'll just
> leave it in break.exp.
Right, I wasn't thinking about the "commands" command specifically --
I think that testcase is more about the support for user-defined
commands / scripting than about random commands, and there are
some tests in there about breakpoint commands.
But really I don't feel strongly about it at all. break.exp is fine.
Thanks,
Pedro Alves