This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] C++-ify parser_state

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Tom Tromey <tom at tromey dot com>
Cc: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
Date: Thu, 30 Nov 2017 00:49:20 -0500
Subject: Re: [RFA] C++-ify parser_state
Authentication-results: sourceware.org; auth=none
References: <20171126174047.23943-1-tom@tromey.com> <82650820-b9f1-c45f-2243-89b47ec00e59@ericsson.com> <878teov3zz.fsf@tromey.com> <a0f4739f7fb6e8d5447211ffb771ac7e@polymtl.ca>

On 2017-11-29 22:54, Simon Marchi wrote:

On 2017-11-29 22:29, Tom Tromey wrote:

Simon> Passing a pointer or reference to the unique_ptr would allow
Simon> the implementations of la_post_parser to modify it directly,
Simon> and avoid the .release ().release ().

I'll look into it.
The realloc thing may be an issue here as well.


I think this should be enough (the commit on top):

https://github.com/simark/binutils-gdb/commits/parser_state

Simon

Oops, I realized I only answered half the question. I added a secondpatch on top.


Simon

References:
- [RFA] C++-ify parser_state
  - From: Tom Tromey
- Re: [RFA] C++-ify parser_state
  - From: Simon Marchi
- Re: [RFA] C++-ify parser_state
  - From: Tom Tromey
- Re: [RFA] C++-ify parser_state
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]