This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA v2 2/2] Update usage text for load, symbol-file
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Wed, 29 Nov 2017 12:04:09 +0000
- Subject: Re: [RFA v2 2/2] Update usage text for load, symbol-file
- Authentication-results: sourceware.org; auth=none
- References: <20171125203531.2891-1-tom@tromey.com> <20171125203531.2891-3-tom@tromey.com>
LGTM, but...
On 11/25/2017 08:35 PM, Tom Tromey wrote:
> This updates the usage text for the load and symbol-file commands.
>
... I was surprised add-symbol-file wasn't getting the READNOW_HELP
treatment too, but actually I think it is:
> @@ -3890,7 +3896,8 @@ Usage: add-symbol-file FILE ADDR [-readnow | -s SECT-NAME SECT-ADDR]...\n\
> ADDR is the starting address of the file's text.\n\
> Each '-s' argument provides a section name and address, and\n\
> should be specified if the data and bss segments are not contiguous\n\
> -with the text. SECT-NAME is a section name to be loaded at SECT-ADDR."),
> +with the text. SECT-NAME is a section name to be loaded at SECT-ADDR.\n"
> +READNOW_HELP),
> &cmdlist);
> set_cmd_completer (c, filename_completer);
here.
> ChangeLog
> 2017-11-25 Tom Tromey <tom@tromey.com>
>
> * symfile.c (_initialize_symfile): Update usage text for
> symbol-file, load.
Ditto, please mention add-symbol-file. Also, $subject.
Thanks,
Pedro Alves