This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 2/2 OBV] Fix build with GCC 8: strncpy ->strcpy
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: gdb-patches at sourceware dot org
- Cc: msebor at redhat dot com
- Date: Wed, 22 Nov 2017 12:21:40 +0000
- Subject: [PATCH 2/2 OBV] Fix build with GCC 8: strncpy ->strcpy
- Authentication-results: sourceware.org; auth=none
- References: <1511353300-11688-1-git-send-email-yao.qi@linaro.org>
Recent gcc 8 trunk emits the warning below,
../../binutils-gdb/gdb/python/py-gdb-readline.c:79:15: error: ‘char* strncpy(char*, const char*, size_t)’ output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation]
strncpy (q, p, n);
~~~~~~~~^~~~~~~~~
../../binutils-gdb/gdb/python/py-gdb-readline.c:73:14: note: length computed here
n = strlen (p);
~~~~~~~^~~
gdb:
2017-11-22 Yao Qi <yao.qi@linaro.org>
* python/py-gdb-readline.c (gdbpy_readline_wrapper): Use strcpy.
---
gdb/ChangeLog | 4 ++++
gdb/python/py-gdb-readline.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index a9e7528..63ae72e 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2017-11-22 Yao Qi <yao.qi@linaro.org>
+ * python/py-gdb-readline.c (gdbpy_readline_wrapper): Use strcpy.
+
+2017-11-22 Yao Qi <yao.qi@linaro.org>
+
* cli/cli-decode.c (help_list): Use memcpy instead of strncpy.
* cp-namespace.c (cp_lookup_transparent_type_loop): Likewise.
diff --git a/gdb/python/py-gdb-readline.c b/gdb/python/py-gdb-readline.c
index a02fa8c..ab14b8c 100644
--- a/gdb/python/py-gdb-readline.c
+++ b/gdb/python/py-gdb-readline.c
@@ -76,7 +76,7 @@ gdbpy_readline_wrapper (FILE *sys_stdin, FILE *sys_stdout,
q = (char *) PyMem_RawMalloc (n + 2);
if (q != NULL)
{
- strncpy (q, p, n);
+ strcpy (q, p);
q[n] = '\n';
q[n + 1] = '\0';
}
--
1.9.1