This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] gdb.ada/minsyms.exp: Don't hardcode the variable's address

From: Pedro Alves <palves at redhat dot com>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: gdb-patches at sourceware dot org
Date: Tue, 21 Nov 2017 17:08:38 +0000
Subject: Re: [PATCH 1/2] gdb.ada/minsyms.exp: Don't hardcode the variable's address
Authentication-results: sourceware.org; auth=none
References: <1511280661-14725-1-git-send-email-palves@redhat.com> <1511280661-14725-2-git-send-email-palves@redhat.com> <20171121165021.53tzinuyifqpcmy3@adacore.com>

On 11/21/2017 04:50 PM, Joel Brobecker wrote:
>> This new testcase has a test that fails like this here:
>>
>>   $1 = (<data variable, no debug info> *) 0x60208c <some_minsym>
>>   (gdb) FAIL: gdb.ada/minsyms.exp: print &some_minsym
>>
>> The problem is that the testcase hardcodes an expected address for the
>> "some_minsym" variable, which obviously isn't stable.
>>
>> Fix that by expecting $hex instead.
>>
>> gdb/testsuite/ChangeLog:
>> 2017-11-21  Pedro Alves  <palves@redhat.com>
>>
>> 	* gdb.ada/minsyms.exp: Accept any address for 'some_minsym'.
> 
> Gaaah. Head-slapping myself on that one.
> 
> Thanks for fixing. Obviously OK :).

:-)

I pushed this one in, to get it out of the way.

Thanks,
Pedro Alves

References:
- [PATCH 0/2] Fix a couple gdb.ada/minsyms.exp problems
  - From: Pedro Alves
- [PATCH 1/2] gdb.ada/minsyms.exp: Don't hardcode the variable's address
  - From: Pedro Alves
- Re: [PATCH 1/2] gdb.ada/minsyms.exp: Don't hardcode the variable's address
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]