This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 25/40] Introduce lookup_name_info and generalize Ada's FULL/WILD name matching
- From: Pedro Alves <palves at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Keith Seitz <keiths at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 8 Nov 2017 16:10:17 +0000
- Subject: Re: [PATCH 25/40] Introduce lookup_name_info and generalize Ada's FULL/WILD name matching
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 719D62CE95E
- References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-26-git-send-email-palves@redhat.com> <596E6C31.1060908@redhat.com> <918c8d65-4c5d-7c04-c2a3-736b7a20d454@redhat.com> <1fa29e48-cbcd-0b88-41ad-f2bd05650b00@redhat.com> <16094f7b-9416-5cda-78fb-7a8d48043e66@redhat.com> <9ab010e3-5873-494b-4296-2c46f847f080@redhat.com> <2b13a06f-d6d5-45d1-c0a0-0efb289a9131@redhat.com> <20171101153810.dc5r27oen5edfwbe@adacore.com>
On 11/01/2017 03:38 PM, Joel Brobecker wrote:
> Hi Pedro,
>
>> This patch touches the Ada code a good deal. It's main goal is
>> to generalize Ada's FULL/WILD name matching, so that C++ can do
>> something very similar. Let me know if you'd like to review it.
>> I've been holding on moving forward with this
>> series because this is a central patch on top of which the
>> rest of the series sits on.
>
> Thanks for drawing my attention to this patch. Overall, it looks
> pretty neat :) and it starts a nice simplification of some of
> the code in ada-lang. Thank you! I admit I didn't read the patch
> in complete details, but enough to understand how it works and
> convince myself that it should actually work. I've also run it
> through our testsuites and found no regressions, neither with
> this patch, nor the series as a whole.
>
> So, to summarize, this looks good to me!
Phew! I admit that I was worried about your internal
testsuites. :-)
Thanks much, I've pushed this one in now (along with a few of the
follow ups, but not the whole series yet).
Thanks,
Pedro Alves