This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Remove symbolp vector
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Wed, 8 Nov 2017 10:22:21 +0000
- Subject: Re: [RFA] Remove symbolp vector
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A51C449029
- References: <20171104161015.16757-1-tom@tromey.com>
On 11/04/2017 04:10 PM, Tom Tromey wrote:
> This removes the symbolp typedef from dwarf2read.c and converts the
> associated VEC uses to std::vector. This fixes a latent possible
> memory leak if an exception were thrown, because there were no
> cleanups installed for these VECs.
>
> Regression tested on the buildbot.
>
> gdb/ChangeLog
> 2017-11-04 Tom Tromey <tom@tromey.com>
>
> * dwarf2read.c (symbolp): Remove typedef.
> (read_func_scope): Use std::vector.
> (process_structure_scope): Use std::vector.
OK.
Thanks,
Pedro Alves