This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 0/4] finish command constification
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 6 Nov 2017 12:03:50 +0000
- Subject: Re: [RFA 0/4] finish command constification
- Authentication-results: sourceware.org; auth=none
- References: <20171016032239.24561-1-tom@tromey.com>
On 17-10-15 21:22:35, Tom Tromey wrote:
> This series completes my command constification efforts. This turned
> out to be much simpler than I had anticipated; partly because I
> started automating some of the changes, and partly because C++ makes
> some incremental refactorings simpler -- as discussed before, in this
> case by allowing the introduction of const overloads.
Thanks for the efforts.
>
> This series touches some files I can't compile. I made a best effort
> to inspect them for const correctness; but it's hard to be sure.
> Given the experience of this series as a whole, I think it is safe to
> say that any required changes will be minimal.
I gave a comment about using x86_64-w64-mingw32 cross compiler to verify
the changes in windows-nat.c. If the build is OK, this patch series
is good to me.
--
Yao (齐尧)