This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 06/13] Replace start_rbreak_breakpoints and end_rbreak_breakpoints

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simon dot marchi at polymtl dot ca>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Sat, 04 Nov 2017 10:25:05 -0600
Subject: Re: [RFA 06/13] Replace start_rbreak_breakpoints and end_rbreak_breakpoints
Authentication-results: sourceware.org; auth=none
References: <20171102223612.3642-1-tom@tromey.com> <20171102223612.3642-7-tom@tromey.com> <368bfe6be1612beb89c174c35e0cc73a@polymtl.ca> <87efpfuwnx.fsf@tromey.com> <d3ddb3d38fe1b92307b2adbf225a8b70@polymtl.ca>

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

>> This also fixes an earlier memory leak regression, by changing
>> "string" to be a std::string.

Simon> LGTM, though I would suggest using string_print, I think it would be
Simon> more readable.

I made this change.

Tom

References:
- [RFA 00/13] more cleanup removal
  - From: Tom Tromey
- [RFA 06/13] Replace start_rbreak_breakpoints and end_rbreak_breakpoints
  - From: Tom Tromey
- Re: [RFA 06/13] Replace start_rbreak_breakpoints and end_rbreak_breakpoints
  - From: Simon Marchi
- Re: [RFA 06/13] Replace start_rbreak_breakpoints and end_rbreak_breakpoints
  - From: Tom Tromey
- Re: [RFA 06/13] Replace start_rbreak_breakpoints and end_rbreak_breakpoints
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]