This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Record nested types
- From: Keith Seitz <keiths at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 20 Oct 2017 11:47:26 -0700
- Subject: Re: [PATCH] Record nested types
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=keiths at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 42F8BC047B97
- References: <20171020182648.5093-1-keiths@redhat.com> <83a80ld5f4.fsf@gnu.org>
On 10/20/2017 11:45 AM, Eli Zaretskii wrote:
>> From: Keith Seitz <keiths@redhat.com>
>> Date: Fri, 20 Oct 2017 11:26:48 -0700
>>
>> --- a/gdb/NEWS
>> +++ b/gdb/NEWS
>> @@ -94,6 +94,10 @@ maint info selftests
>> starti
>> Start the debugged program stopping at the first instruction.
>>
>> +set|show print type nested-type-limit
>> + Set and show the number of recursively defined nested types that the
>> + type printer will show.
>
> Not sure why you used "recursive" here, I think it just makes the
> intent more mysterious. How about this wording instead:
>
> Set and show the limit of the nesting level for nested types that
> the type printer will show.
That's much better!
>> +@kindex set print type nested-type-limit
>> +@item set print type nested-type-limit @var{limit}
>> +Set the recursive display limit of nested types that the type printer will
>> +show. A @var{limit} of -1 is treated as unlimited. By default, the type
>> +printer will not show any nested types defined in classes.
>
> Same here.
I'll make both changes.
Thank you!
Keith