This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] ada: Use std::string in print_dynamic_range_bound

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Yao Qi <qiyaoltc at gmail dot com>
Cc: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
Date: Fri, 13 Oct 2017 22:46:42 -0400
Subject: Re: [PATCH] ada: Use std::string in print_dynamic_range_bound
Authentication-results: sourceware.org; auth=none
References: <1507902347-7971-1-git-send-email-simon.marchi@ericsson.com> <20171013202945.GL8425@1170ee0b50d5>

On 2017-10-13 16:29, Yao Qi wrote:

On 17-10-13 09:45:47, Simon Marchi wrote:

Replace this usage of GROW_VECT with an std::string.  I don't think
there's a reason for this variable to be static, other than it was
cumbersome to manage its lifetime (i.e. use a cleanup) before.

Tested by comparing the gdb.ada/*.exp test results before and afterthe

patch.

gdb/ChangeLog:

	* ada-typeprint.c (print_dynamic_range_bound): Use std::string.


Patch is good to me.


Thanks, pushed.

References:
- [PATCH] ada: Use std::string in print_dynamic_range_bound
  - From: Simon Marchi
- Re: [PATCH] ada: Use std::string in print_dynamic_range_bound
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]