This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v5 1/3] Introduce gdb_tilde_expand
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Eli Zaretskii <eliz at gnu dot org>
- Date: Wed, 04 Oct 2017 02:09:15 -0400
- Subject: Re: [PATCH v5 1/3] Introduce gdb_tilde_expand
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CCCB87E459
- References: <20170912042325.14927-1-sergiodj@redhat.com> <20170929225852.21872-1-sergiodj@redhat.com> <20170929225852.21872-2-sergiodj@redhat.com> <ec96a774-2ae1-f86d-f7ac-92047c9c830a@redhat.com>
On Tuesday, October 03 2017, Pedro Alves wrote:
> On 09/29/2017 11:58 PM, Sergio Durigan Junior wrote:
>> Currently, whenever we want to handle paths provided by the user and
>> perform tilde expansion on GDB, we rely on "tilde_expand", which comes
>> from readline. This was enough for our use cases so far, but the
>> situation will change when we start dealing with paths on gdbserver as
>> well, which is what the next patches implement.
>>
>> Unfortunately it is not possible to use "tilde_expand" in this case
>> because gdbserver doesn't use readline. For that reason I decided to
>> implement a new "gdb_tilde_expand" function, which is basically a
>> wrapper for "glob" and its GNU extension, GLOB_TILDE_CHECK. With the
>> import of the "glob" module from gnulib, this is a no-brainer.
>>
>
> OK.
Thanks, pushed.
7da0a8867419fc4a2a64d49cc71a14bd145cebff
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/