This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 00/12] some minor cleanup removals


On 09/28/2017 10:04 PM, Sergio Durigan Junior wrote:
> On Thursday, September 28 2017, Tom Tromey wrote:
> 
>> This removes a number of cleanups, generally string related.
>>
>> I introduced string_vprintf to allow the use of std::string in some of
>> these patches.
>>
>> The final patch just removes a couple of unused declarations; I would
>> have checked it in as obvious, but it was more convenient to just
>> leave it in this series.
> 
> FWIW, I looked at the patches and they seem OK to me.
> 
> Thanks for doing all these cleanups!

Seconded!

I sent a few comments, but overall it looks good to me too.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]