This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 1/5] Remove regcache_xmalloc
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 26 Sep 2017 01:10:50 -0400
- Subject: Re: [RFA 1/5] Remove regcache_xmalloc
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EA9A7356F6
- References: <20170924024608.4346-1-tom@tromey.com> <20170924024608.4346-2-tom@tromey.com> <87h8vqkqrm.fsf@tromey.com>
On Tuesday, September 26 2017, Tom Tromey wrote:
>>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>
> Tom> + struct regcache *regcache = new regcache (data.gdbarch, aspace);
>
> The builder complained about this line.
> It had to be 'new struct regcache' instead.
>
> However, this was change in a subsequent commit, so my try run didn't
> catch it. I suppose I will have to start doing try runs for each
> individual patch; which is kind of a pain :(
Yeah, sorry about that :-(.
On a side note, I was talking to mjw the other day about setting up
"special try branches" for some people. I still don't know how that
would work internally on BuildBot, but it would address this problem of
testing several commits.
A problem I foresee with this approach is the extra load on the slaves;
some of them are already working around the clock to keep up. Anyway, I
don't want to hijack the thread, just wanted to say something related to
what happened.
> Anyway, I'm sorry about this. The only good thing is that you probably
> won't hit this problem unless you bisect.
Before I get crucified because of the "spam" generated: each breakage
e-mail is related to one specific builder. Sometimes a breakage happens
only on e.g. ARM, so you'd get e-mails just for this architecture.
Anyway, sorry about the number of messages; it's currently not possible
to merge all of the reports into one single message, although it may be
possible to thread them. Unfortunately I don't have time right now to
look into this, but we don't have a lot of breakages anyway...
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/