This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 0/5] remove cleanups from regcache
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 26 Sep 2017 00:08:38 +0000
- Subject: Re: [RFA 0/5] remove cleanups from regcache
- Authentication-results: sourceware.org; auth=none
- References: <20170924024608.4346-1-tom@tromey.com>
On 17-09-23 20:46:03, Tom Tromey wrote:
> This series removes the remaining cleanups from regcache and related
> code.
>
> First, it removes regcache_xmalloc and regcache_xfree in favor of
> using plain new and delete everywhere. These were already used under
> the hood; this just removes a layer of indirection.
>
> Second, the main patch, #3, removes a cleanup by using
> std::unique_ptr.
>
> The final two patches remove some cleanups locally in regcache.c by
> using standard techniques.
>
> Regression tested by the buildbot.
>
> Tom
>
Hi Tom,
I gave comments to one patch, but the rest of them are good to me. I
wanted to remove cleanup from regcache for a while, but don't have a
chance. Thanks for doing this.
--
Yao (齐尧)