This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 1/5] Import "glob" and "getcwd" modules from gnulib

On Friday, September 22 2017, Pedro Alves wrote:

> On 09/21/2017 11:59 PM, Sergio Durigan Junior wrote:
>
>> 	* gnulib/import/m4/gnulib-cache.m4: Regenerate
>
> Missing period.

Fixed.

>> 	* ser-tcp.c: Undefine "close" before redefining it.
>
> diff --git a/gdb/ser-tcp.c b/gdb/ser-tcp.c
> index f35991c..c8be37b 100644
> --- a/gdb/ser-tcp.c
> +++ b/gdb/ser-tcp.c
> @@ -42,6 +42,7 @@
>>  #ifndef ETIMEDOUT
>>  #define ETIMEDOUT WSAETIMEDOUT
>>  #endif
>> +#undef close
>>  #define close(fd) closesocket (fd)
>>  #define ioctl ioctlsocket
>>  #else
>
> Please add a comment.  Something like:
>
> /* Gnulib defines close too, but gnulib's replacement
>    doesn't call closesocket unless we import the
>    socketlib module.  */

Added.

> Otherwise OK.

Pushed.

6ec2e0f5bddc69d55e09fe56792edf7a109ff8ae

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]