This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Remove make_cleanup_restore_target_terminal
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Wed, 20 Sep 2017 17:21:07 +0100
- Subject: Re: [RFA] Remove make_cleanup_restore_target_terminal
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 52E0C80465
- References: <20170920160404.20543-1-tom@tromey.com>
On 09/20/2017 05:04 PM, Tom Tromey wrote:
> This removes make_cleanup_restore_target_terminal and generally
> C++-ifies target terminal handling. It changes all target_terminal_*
> functions to be static members of a new target_terminal class and
> changes the cleanup to be a scoped_* class.
> make_cleanup_override_quit_handler is also removed in favor of simply
> using scoped_restore.
>
> Note that there are some files in this patch that I could not compile.
> Considering that some of the rewrites were automated, and that none of
> these files involed cleanups, I feel that this is relatively safe.
>
> Regression tested by the buildbot.
Looks fine to me.
> +
> + static terminal_state terminal_state;// = terminal_is_ours;
> +};
>
Stale comment?
Thanks,
Pedro Alves