This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Use std::vector on tdesc->reg_defs (gdbserver/tdesc.h)
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Yao Qi <yao dot qi at linaro dot org>
- Date: Fri, 15 Sep 2017 23:53:29 -0400
- Subject: Re: [PATCH] Use std::vector on tdesc->reg_defs (gdbserver/tdesc.h)
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A3BB0129862
- References: <20170910171249.28470-1-sergiodj@redhat.com> <e28227bbecf218daaeb28d82d7409574@polymtl.ca>
On Sunday, September 10 2017, Simon Marchi wrote:
> On 2017-09-10 19:12, Sergio Durigan Junior wrote:
>> This is a followup patch to the build breakage fix on AArch64. While
>> doing the fix, I found it better to convert tdesc->reg_defs (on
>> gdbserver/tdesc.h) from using VEC to using std::vector. This makes
>> the code easier to read and maintain, and also is one more step
>> towards the C++fication.
>>
>> Regtested on BuildBot.
>
> Hi Sergio,
>
> Thanks for the patch. It looks good to me, but Yao might want to look
> at it since it changes an area he knows well. So leave the patch up
> for a few days just in case, if you haven't heard anything new in a
> week, you can push.
Pushed now.
c4dfafabc575f4995a5aa18241adc275e63c846c
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/