This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/2] gdbserver: Move detach code to its own function

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Pedro Alves <palves at redhat dot com>
Cc: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
Date: Fri, 15 Sep 2017 18:01:09 +0200
Subject: Re: [PATCH 2/2] gdbserver: Move detach code to its own function
Authentication-results: sourceware.org; auth=none
References: <1505482514-10206-1-git-send-email-simon.marchi@ericsson.com> <1505482514-10206-2-git-send-email-simon.marchi@ericsson.com> <eca37e02-fd91-c91b-0bb8-54ef983be38b@redhat.com>

On 2017-09-15 16:12, Pedro Alves wrote:

On 09/15/2017 02:35 PM, Simon Marchi wrote:

 }

+static void
+handle_detach (char *own_buf)
+{


Patch looks fine, but could you add some intro comment:

/* Handle the "D" packet.  */


Doh, of course.  I fixed it and pushed both patches.

Thanks,

Simon

References:
- [PATCH 1/2] Deduplicate require_running macros and move them up
  - From: Simon Marchi
- [PATCH 2/2] gdbserver: Move detach code to its own function
  - From: Simon Marchi
- Re: [PATCH 2/2] gdbserver: Move detach code to its own function
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]