This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] Deduplicate require_running macros and move them up
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Fri, 15 Sep 2017 15:13:43 +0100
- Subject: Re: [PATCH 1/2] Deduplicate require_running macros and move them up
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DA1594E4C2
- References: <1505482514-10206-1-git-send-email-simon.marchi@ericsson.com>
On 09/15/2017 02:35 PM, Simon Marchi wrote:
> I find it very confusing to define the require_running in the middle of
> the file, and re-define it to something else later in the middle of the
> same file. I think it would be better if those macros had different
> names so that we know exactly what they do.
Indeed. Looks good to me.
Thanks,
Pedro Alves