This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, gdb/testsuite] Fix compare-sections.exp FAIL
- From: Pedro Alves <palves at redhat dot com>
- To: Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>, GDB Patches <gdb-patches at sourceware dot org>
- Date: Thu, 14 Sep 2017 14:26:56 +0100
- Subject: Re: [PATCH, gdb/testsuite] Fix compare-sections.exp FAIL
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4EAA97EA8E
- References: <33d0f2eb-4802-8b06-44bf-3e4299c5fdb4@foss.arm.com> <a92d3df9-4e0f-46da-4887-e0e623f7fb8d@redhat.com> <a0513d9a-1c12-a007-d17a-717a211da4a8@foss.arm.com>
Hi Thomas,
On 09/12/2017 04:24 PM, Thomas Preudhomme wrote:
> Hi Pedro,
>
> Thanks for the review. Please find an updated patch attached. Updated
> ChangeLog entry and description are as follow:
>
> compare-sections.exp has two cases that are not handled appropriately:
> 1) value read from read-only section is negative
> 2) error while patching that section
>
> This patch adapts the regular expression to allow a minus sign to deal
> with 1)
The above is stale. It should now talk about /d vs /u.
Could you please update?
> Is this ok for master?
OK with commit log fixed, and ...
On 09/12/2017 04:24 PM, Thomas Preudhomme wrote:
> @@ -136,6 +136,9 @@ with_test_prefix "read-only" {
> set written -1
> set test "corrupt read-only section"
> gdb_test_multiple "print /d *(unsigned char *) $ro_address = $patch" "$test" {
... this should be switched to "/u" too.
> + -re " = .*Cannot access memory at address $ro_address.*$gdb_prompt $" {
> + pass "$test (cannot write)"
Thanks,
Pedro Alves