This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, gdb/testsuite] Fix compare-sections.exp FAIL


Hi Thomas,

On 09/12/2017 04:24 PM, Thomas Preudhomme wrote:
> Hi Pedro,
> 
> Thanks for the review. Please find an updated patch attached. Updated
> ChangeLog entry and description are as follow:
> 
> compare-sections.exp has two cases that are not handled appropriately:
> 1) value read from read-only section is negative
> 2) error while patching that section
> 
> This patch adapts the regular expression to allow a minus sign to deal
> with 1) 

The above is stale.  It should now talk about /d vs /u.
Could you please update?

> Is this ok for master?

OK with commit log fixed, and ...

On 09/12/2017 04:24 PM, Thomas Preudhomme wrote:
> @@ -136,6 +136,9 @@ with_test_prefix "read-only" {
>      set written -1
>      set test "corrupt read-only section"
>      gdb_test_multiple "print /d *(unsigned char *) $ro_address = $patch" "$test" {

... this should be switched to "/u" too.

> +	-re " = .*Cannot access memory at address $ro_address.*$gdb_prompt $" {
> +	    pass "$test (cannot write)"

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]