This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA 1/4] Use gdb::def_vector in func_command
- From: Tom Tromey <tom at tromey dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tom at tromey dot com>
- Date: Fri, 8 Sep 2017 18:41:26 -0600
- Subject: [RFA 1/4] Use gdb::def_vector in func_command
- Authentication-results: sourceware.org; auth=none
- References: <20170909004129.28782-1-tom@tromey.com>
This changes func_command to use gdb::def_vector, removing a cleanup.
gdb/ChangeLog
2017-09-08 Tom Tromey <tom@tromey.com>
* stack.c (func_command): Use gdb::def_vector.
---
gdb/ChangeLog | 4 ++++
gdb/stack.c | 7 ++-----
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 96369d5..b7f83a4 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2017-09-08 Tom Tromey <tom@tromey.com>
+
+ * stack.c (func_command): Use gdb::def_vector.
+
2017-09-08 Keith Seitz <keiths@redhat.com>
* dwarf2read.c (struct field_info) <fnfields>: Remove unused
diff --git a/gdb/stack.c b/gdb/stack.c
index 8a066b2..36c1e46 100644
--- a/gdb/stack.c
+++ b/gdb/stack.c
@@ -52,6 +52,7 @@
#include "symfile.h"
#include "extension.h"
#include "observer.h"
+#include "common/def-vector.h"
/* The possible choices of "set print frame-arguments", and the value
of this setting. */
@@ -2521,7 +2522,6 @@ func_command (char *arg, int from_tty)
struct frame_info *frame;
int found = 0;
int level = 1;
- struct function_bounds *func_bounds = NULL;
if (arg == NULL)
return;
@@ -2529,8 +2529,7 @@ func_command (char *arg, int from_tty)
frame = get_current_frame ();
std::vector<symtab_and_line> sals
= decode_line_with_current_source (arg, DECODE_LINE_FUNFIRSTLINE);
- func_bounds = XNEWVEC (struct function_bounds, sals.size ());
- struct cleanup *cleanups = make_cleanup (xfree, func_bounds);
+ gdb::def_vector<function_bounds> func_bounds (sals.size ());
for (size_t i = 0; (i < sals.size () && !found); i++)
{
if (sals[i].pspace != current_program_space)
@@ -2557,8 +2556,6 @@ func_command (char *arg, int from_tty)
}
while (!found && level == 0);
- do_cleanups (cleanups);
-
if (!found)
printf_filtered (_("'%s' not within current stack frame.\n"), arg);
else if (frame != get_selected_frame (NULL))
--
2.9.4