This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Remove unnecessary function prototypes.
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: John Baldwin <jhb at FreeBSD dot org>, <gdb-patches at sourceware dot org>
- Date: Thu, 7 Sep 2017 22:53:11 +0200
- Subject: Re: [PATCH] Remove unnecessary function prototypes.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon dot marchi at ericsson dot com;
- References: <20170907195343.7747-1-jhb@FreeBSD.org>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 2017-09-07 09:53 PM, John Baldwin wrote:
> These prototypes were required when compiling GDB as C but are not
> required for C++.
Thanks a lot for doing this! This patch is ok. Just to understand your
intentions, do you plan to remove the remaining ones as well later?
Before patch:
$ egrep "(void|initialize_file_ftype) _initialize_" */*.c *.c | wc -l
346
After patch:
$ egrep "(void|initialize_file_ftype) _initialize_" */*.c *.c | wc -l
68
In the end, I think we'll be able to move the initialize_file_ftype typedef
to the generated init.c file, since it won't be used anywhere else.
Simon