This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch+7.12.1 1/2] Code cleanup: write_exp_msymbol: +is_tls
- From: Pedro Alves <palves at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 6 Sep 2017 13:14:04 +0100
- Subject: Re: [patch+7.12.1 1/2] Code cleanup: write_exp_msymbol: +is_tls
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4E71F5D687
- References: <20161009185641.GA13645@host1.jankratochvil.net>
On 10/09/2016 07:56 PM, Jan Kratochvil wrote:
> Hi,
>
> no functionality change, for patch 2/2.
> /* The minimal symbol might point to a function descriptor;
> resolve it to the actual code address instead. */
> pc = gdbarch_convert_from_func_ptr_addr (gdbarch, addr, ¤t_target);
> - if (pc != addr)
> + if (!is_tls && pc != addr)
This bit might be a functionality change / fix, AFAICS. I pushed in
the other patch without this bit, because:
- it looked like we could skip the gdbarch_convert_from_func_ptr_addr
call too?
- I wondered whether for TLS function pointers we should
actually translate the TLS address and then
still see if the translated address points to a function
descriptor that needs to be resolved, like in the non-TLS case.
At this point, it seemed better to leave it be until we add
a testcase with a TLS function pointer.
Thanks,
Pedro Alves