This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdbserver Makefile: don't delete intermediary files
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Mon, 4 Sep 2017 12:34:40 +0100
- Subject: Re: [PATCH] gdbserver Makefile: don't delete intermediary files
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0007CC04B930
- References: <1504428708-17321-1-git-send-email-simon.marchi@ericsson.com>
On 09/03/2017 09:51 AM, Simon Marchi wrote:
> If you "make" from scratch in gdbserver/, you'll notice that make
> deletes the files it considers as intermediary at the end:
>
> $ make clean && make
> ...
> rm i386-mmx-linux-generated.c x32-avx-avx512-linux-generated.c ...
>
> Then, if you type make again, make will rebuild these files and rebuild
> gdbserver.
Ah, this has been annoying me for a while.
> To avoid this, we can add the .SECONDARY special target. If
> it has no pre-requisites, all intermediary files will be kept.
>
> gdb/gdbservef/ChangeLog:
Typo "gdbservef".
>
> * Makefile.in (.SECONDARY): Define target.
LGTM.
> ---
> gdb/gdbserver/Makefile.in | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in
> index 6cd0959..e43a929 100644
> --- a/gdb/gdbserver/Makefile.in
> +++ b/gdb/gdbserver/Makefile.in
> @@ -632,4 +632,7 @@ endif
> # Disable implicit make rules.
> include $(srcdir)/../disable-implicit-rules.mk
>
> +# Do not delete intermediate files (e.g. *-generated.c).
> +.SECONDARY:
> +
> # This is the end of "Makefile.in".
>
Thanks,
Pedro Alves