Re: [PATCH/RFC] Implement the ability to set the current working directory in GDBserver

[Eli Zaretskii <eliz at gnu dot org>]

> From: Sergio Durigan Junior <sergiodj@redhat.com>
> Cc: Pedro Alves <palves@redhat.com>,
> 	Eli Zaretskii <eliz@gnu.org>,
> 	Sergio Durigan Junior <sergiodj@redhat.com>
> Date: Wed, 30 Aug 2017 00:38:11 -0400
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -17,11 +17,22 @@
>       "target remote", you can disable the startup with shell by using the
>       new "--no-startup-with-shell" GDBserver command line option.
>  
> +  ** On Unix systems, GDBserver is now able to enter a directory
> +     before starting an inferior.

Can you tell why this is limited to Unix systems?  The chdir function
is available much wider than just on Unix.

> +     This is done by using the "cd" command in GDB, which instructs it
> +     to tell GDBserver about this directory change the next time an
> +     inferior is run.  If you want to make GDBserver enter the
> +     directory your GDB is currently in, you can do a "cd ." in GDB.

Couldn't GDB do this "cd ." step under the hood, without bothering
users with that?

> +Whenever you specify a new working directory in @value{GDBN}, and if
> +you are performing a remote debug (@pxref{Remote Debugging}), this
> +change will be reflected in @command{gdbserver} the next time you run
> +the program being debugged (@pxref{QSetWorkingDir packet}).  Sometimes
> +you may want to make @command{gdbserver} enter a directory in which
> +@value{GDBN} is already in; in this case, you can perform a @code{cd
> +.} which will not change the current directory in @value{GDBN} but
> +will force @command{gdbserver} to enter it.

The "@code{cd .}" part should be @kbd{cd .}, and I'd take it in @w{..}
for a good measure, to prevent it from being broken between 2 lines.

> +This packet is only transmitted when the user issues a @code{cd}
> +command in @value{GDBN} (@xref{Working Directory, ,Your Program's
> +Working Directory}).

The @xref should be @pxref, as the former is not appropriate in
parentheses.

The documentation parts are okay with these nits fixed.

Thanks.