This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Oh dear. I regret to inform you that commit 'remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type' might be unfortunate
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: Joel Brobecker <brobecker at adacore dot com>, GDB <gdb-patches at sourceware dot org>
- Date: Sat, 26 Aug 2017 14:04:50 -0700
- Subject: Re: Oh dear. I regret to inform you that commit 'remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type' might be unfortunate
- Authentication-results: sourceware.org; auth=none
- References: <E1dlPHW-0007LM-Eg@kwanyin.sergiodj.net> <20170826123906.wg5s7qsm65lklk5s@adacore.com> <87mv6m9kbt.fsf@redhat.com>
On Sat, Aug 26, 2017 at 12:53 PM, Sergio Durigan Junior
<sergiodj@redhat.com> wrote:
> On Saturday, August 26 2017, Joel Brobecker wrote:
>
>> Hello,
>>
>> On Fri, Aug 25, 2017 at 08:48:58PM -0400, gdb-buildbot@sergiodj.net wrote:
>>> My lords, ladies, gentlemen, members of the public.
>>>
>>> It is a matter of great regret and sadness to inform you that commit:
>>>
>>> remove param "dispp" from ada-lang.c::ada_lookup_struct_elt_type
>>> 988f6b3dc615173d6d78a76ac26c109b4582da74
>>>
>>> might have made GDB unwell. Since I am just your Butler BuildBot,
>>> I kindly ask that a human superior officer double-check this.
>>
>> My change only touches a static function in ada-lang.c, while
>> the error is reported inside sparc64-tdep. Maybe an earlier commit?
>
> Yeah, sorry about these messages. BuildBot is currently not smart
> enough to figure out that the failure was not introduced by the last
> commit. One solution, proposed by Pedro, is to send the breakage e-mail
> to the authors of all commits that haven't been tested until the last
> one, but that's also not easy to do... I'll investigate and see if
> there's any other way.
>
You can keep track of errors for the current commit and do
not send an email if the next commit doesn't change errors.
--
H.J.