This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patchv2+8.0] DWARF-5 Fix DW_FORM_implicit_const
- From: Pedro Alves <palves at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 24 Aug 2017 13:59:44 +0100
- Subject: Re: [patchv2+8.0] DWARF-5 Fix DW_FORM_implicit_const
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6A14A4ACBD
- References: <20170622203308.GA23353@host1.jankratochvil.net> <2f19870d-0c08-193f-1971-b58333039f40@redhat.com> <20170824125700.GA7891@host1.jankratochvil.net>
On 08/24/2017 01:57 PM, Jan Kratochvil wrote:
> On Thu, 24 Aug 2017 01:08:01 +0200, Pedro Alves wrote:
>> Wouldn't that be more direct and to the point? If I'm imagining
>> that version of the patch correctly, that'd seem like a
>> more obvious choice to me. The proposed version looks like is
>> frobbing the form so that DW_FORM_sdata so that those two other
>> functions end up doing the right thing as side effect. Right?
>> Is there some advantage to doing it the sdata way? It kind of feels
>> like a hack, but maybe I'm missing something.
>
> Is this patch OK?
OK.
>
> Regression tested on fedora-rawhide {x86_64,x86_64-m32,i686}.
Thanks,
Pedro Alves