This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 39/40] Breakpoints in symbols with ABI tags (PR c++/19436)
- From: Keith Seitz <keiths at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 9 Aug 2017 12:34:22 -0700
- Subject: Re: [PATCH 39/40] Breakpoints in symbols with ABI tags (PR c++/19436)
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=keiths at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com ACAF9138510
- References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-40-git-send-email-palves@redhat.com>
On 06/02/2017 05:22 AM, Pedro Alves wrote:
> gdb/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * completer.h (completion_match_for_lcd) <match,
> mark_ignored_range>: New methods.
> <finish>: Consider ignored ranges.
> <clear>: Clear ignored ranges.
> <m_ignored_ranges, m_finished_storage>: New fields.
> * cp-support.c (cp_search_name_hash): Ignore ABI tags.
> (cp_symbol_name_matches_1, cp_fq_symbol_name_matches): Pass the
> completion_match_for_lcd pointer to strncmp_iw_with_mode.
> (test_cp_symbol_name_cmp): Add [abi:...] tags unit tests.
> * language.c (default_symbol_name_matcher): Pass the
> completion_match_for_lcd pointer to strncmp_iw_with_mode.
> * linespec.c (linespec_lexer_lex_string): Don't tokenize ABI tags.
> * utils.c (skip_abi_tag): New function.
> (strncmp_iw_with_mode): Add completion_match_for_lcd parameter.
> Handle ABI tags.
> * utils.h (strncmp_iw_with_mode): Add completion_match_for_lcd
> parameter.
>
> gdb/testsuite/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * gdb.linespec/cpls-abi-tag.cc: New file.
> * gdb.linespec/cpls-abi-tag.exp: New file.
Just one little thing: the PR# isn't mentioned in the ChangeLogs.
[This is also c++/18601, but I've marked that as a dup of this bug which is
discussed more.]
Keith