This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix memory leak in cp-support.c (cp_canonicalize_string)

From: Yao Qi <qiyaoltc at gmail dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Alex Lindsay <alexlindsay239 at gmail dot com>, gdb-patches at sourceware dot org
Date: Wed, 09 Aug 2017 14:41:48 +0100
Subject: Re: [PATCH] Fix memory leak in cp-support.c (cp_canonicalize_string)
Authentication-results: sourceware.org; auth=none
References: <20170807201821.25207-1-alexlindsay239@gmail.com> <86k22dyno6.fsf@gmail.com> <2c88c7cb-dca8-7bd7-fe01-ee0c4a9d0e94@redhat.com> <2675604a-4460-81e3-93f3-21e34727fe12@redhat.com>

Pedro Alves <palves@redhat.com> writes:

Patch is good to me.

> -	      n = cp_comp_to_string (&newobj, 100);
> +	      gdb::unique_xmalloc_ptr<char> n = cp_comp_to_string (&newobj, 100);

Nit, it is too long.

-- 
Yao (齐尧)

Follow-Ups:
- Re: [PATCH] Fix memory leak in cp-support.c (cp_canonicalize_string)
  - From: Pedro Alves

References:
- [PATCH] Fix memory leak in cp-support.c (cp_canonicalize_string)
  - From: Alex Lindsay
- Re: [PATCH] Fix memory leak in cp-support.c (cp_canonicalize_string)
  - From: Yao Qi
- Re: [PATCH] Fix memory leak in cp-support.c (cp_canonicalize_string)
  - From: Pedro Alves
- Re: [PATCH] Fix memory leak in cp-support.c (cp_canonicalize_string)
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]