This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 09/23] Remove close cleanup
- From: Tom Tromey <tom at tromey dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>
- Cc: Tom Tromey <tom at tromey dot com>, Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Tue, 01 Aug 2017 15:41:28 -0600
- Subject: Re: [RFA 09/23] Remove close cleanup
- Authentication-results: sourceware.org; auth=none
- References: <20170503224626.2818-1-tom@tromey.com> <20170503224626.2818-10-tom@tromey.com> <ca2efb7d-21f7-f935-fbe3-86d09916d0f0@redhat.com> <87iniom59v.fsf@tromey.com> <d1f02516a66da2195f8fbb1bd7a6fce0@polymtl.ca>
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> Instead of finding a solution to preserve errno, I think we should
Simon> return it explicitly when needed, it would be more robust and easier
Simon> to follow the trail where the value comes from. That would mean
Simon> changing
Simon> static enum mnsh_fs_code
Simon> linux_mntns_access_fs (pid_t pid)
Simon> to
Simon> static enum mnsh_fs_code
Simon> linux_mntns_access_fs (pid_t pid, int *errnop)
Simon> and possibly others. In that case, *ERRNOP would be set if
Simon> MNSH_FS_ERROR is returned.
I think somebody else should take this then.
I will see if I can drop this patch from the series.
Tom