Re: [PATCH v2] Align natural-format register values to the same column

[Simon Marchi <simon dot marchi at polymtl dot ca>]

On 2017-07-26 12:49, Ruslan Kabatsayev wrote:
> > > @@ -2280,9 +2289,15 @@ default_print_one_register_info (struct 
> > > ui_file
> > > *file,
> > >  {
> > >    struct type *regtype = value_type (val);
> > >    int print_raw_format;
> > > +  string_file format_stream;
> > > +  enum tab_stops
> > > +    {
> > > +	value_column_1=15,
> > > +	value_column_2=32,
> >
> > Perhaps those could have more explicit names, like "column_hex" and
> > "column_natural"?
> This was my first thought, but then I noticed that for floating-point
> registers we have "(raw 0x....)" on the right column and "1.32536e+52"
> on the left one. Do you still think it's OK to name the left column hex
> and the right one natural?

Ah I see.  Well that seems inconsistent, I wonder if there's a reason 
it's this way.  In that case, I'm fine with the names.

Simon