This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 20/40] Eliminate block_iter_name_*
- From: Pedro Alves <palves at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>, gdb-patches at sourceware dot org
- Date: Thu, 20 Jul 2017 18:05:46 +0100
- Subject: Re: [PATCH 20/40] Eliminate block_iter_name_*
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 569E12C1529
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 569E12C1529
- References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-21-git-send-email-palves@redhat.com> <596D144D.9040206@redhat.com>
On 07/17/2017 08:47 PM, Keith Seitz wrote:
> On 06/02/2017 05:22 AM, Pedro Alves wrote:
>> This patch gets rid of block_iter_name_* as being unnecessary. It's
>> the same as calling block_iter_match_*, and passing strcmp_iw as
>> comparison routine.
>
> I was curious how this situation arose. Looking at the archives, I think it safe to say that someone was playing it safe when extending the interfaces for Ada. [I certainly don't blame people for playing it safe. I do it all the time.]
>
> So, LGTM.
Thanks for checking that! I pushed it in now.
--
Pedro Alves