This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 25/40] Introduce lookup_name_info and generalize Ada's FULL/WILD name matching
- From: Pedro Alves <palves at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>, gdb-patches at sourceware dot org
- Date: Tue, 18 Jul 2017 23:30:55 +0100
- Subject: Re: [PATCH 25/40] Introduce lookup_name_info and generalize Ada's FULL/WILD name matching
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9F682C04B939
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9F682C04B939
- References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-26-git-send-email-palves@redhat.com> <596E6C31.1060908@redhat.com>
On 07/18/2017 09:14 PM, Keith Seitz wrote:
> On 06/02/2017 05:22 AM, Pedro Alves wrote:
>
> utils.[ch]? Wrong ChangeLog?
Whoops.
>
> I'm seeing regressions with this patch (no subsequent patch seems to fix it, either):
>
> FAIL: gdb.ada/arrayidx.exp: print u_one_two_three, indexes off
> FAIL: gdb.ada/arrayidx.exp: print u_one_two_three
> FAIL: gdb.ada/disc_arr_bound.exp: print r
> FAIL: gdb.ada/disc_arr_bound.exp: print r.a
> FAIL: gdb.ada/mi_dyn_arr.exp: create bt varobj (unexpected output)
> FAIL: gdb.ada/pckd_arr_ren.exp: print var
>
Fun. From the file names, sounds like they're all related to dynamic arrays.
I don't see those. Likely this is compiler related. I'm on F23, with
GNAT 5.3.1.
This patch actually causes a progression for me:
-KFAIL: gdb.ada/str_ref_cmp.exp: operator = works for strings (PRMS: ada/12607)
-UNTESTED: gdb.ada/str_ref_cmp.exp: str_ref_cmp.exp
+PASS: gdb.ada/str_ref_cmp.exp: operator = works for strings
+PASS: gdb.ada/str_ref_cmp.exp: print String_Var (1 .. 3) = "Hel"
+PASS: gdb.ada/str_ref_cmp.exp: print String_Var (1 .. 3) = "hel"
(triple-checked this.)
Here are the gdb.ada/ *FAILs I see before the patch:
$ grep FAIL gdb.sum
KFAIL: gdb.ada/array_ptr_renaming.exp: print ntp (PRMS: gdb/NNNN)
KFAIL: gdb.ada/bad-task-bp-keyword.exp: break *break_me'address TASK Task TaSK 2 (PRMS: gdb/14111)
XFAIL: gdb.ada/dyn_loc.exp: info locals
XFAIL: gdb.ada/funcall_ref.exp: p get ("Hello world!")
XFAIL: gdb.ada/funcall_ref.exp: ptype get ("Hello world!")
FAIL: gdb.ada/fun_renaming.exp: print next(1) (timeout)
FAIL: gdb.ada/fun_renaming.exp: print n(1)
XFAIL: gdb.ada/fun_renaming.exp: print renamed_next(1)
XFAIL: gdb.ada/fun_renaming.exp: print pack.renamed_next(1)
FAIL: gdb.ada/mi_ex_cond.exp: catch C_E if i = 2 (unexpected output)
FAIL: gdb.ada/mi_ex_cond.exp: run to exception catchpoint hit (unknown output after running)
FAIL: gdb.ada/mi_ex_cond.exp: -break-list (unexpected output)
KFAIL: gdb.ada/str_ref_cmp.exp: operator = works for strings (PRMS: ada/12607)
Thanks,
Pedro Alves