This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 09/40] Rename make_symbol_completion_list_fn -> symbol_completer
- From: Pedro Alves <palves at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>, gdb-patches at sourceware dot org, Yao Qi <qiyaoltc at gmail dot com>
- Date: Mon, 17 Jul 2017 12:00:05 +0100
- Subject: Re: [PATCH 09/40] Rename make_symbol_completion_list_fn -> symbol_completer
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 5B1184DD49
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5B1184DD49
- References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-10-git-send-email-palves@redhat.com> <5967DC1F.309@redhat.com>
On 07/13/2017 09:46 PM, Keith Seitz wrote:
> On 06/02/2017 05:22 AM, Pedro Alves wrote:
>> "make_symbol_completion_list_fn" is odly named when you look at a list
>> of "standard" completers, like the Python/Guild completer lists
>> adjusted by this patch. Rename / move it to completers.h/c, for
>> consistency.
>
> Oh, man, I totally agree. make_symbol_completion_list_fn sounds more like a typedef name!
>
> And who could possibly complain about shortening symtab.[ch]. Those files are already a little bloated with non-symtab stuff.
>
> I see no issues with this patch.
Thanks guys. I pushed this one in.
--
Pedro Alves