This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] Include the fs_base and gs_base registers in amd64 target descriptions.
- From: John Baldwin <jhb at freebsd dot org>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 11 Jul 2017 09:11:35 -0700
- Subject: Re: [PATCH 1/2] Include the fs_base and gs_base registers in amd64 target descriptions.
- Authentication-results: sourceware.org; auth=none
- References: <20170627224948.99138-1-jhb@FreeBSD.org> <20170627224948.99138-2-jhb@FreeBSD.org> <86shi3qu5m.fsf@gmail.com>
On Tuesday, July 11, 2017 09:01:25 AM Yao Qi wrote:
> John Baldwin <jhb@FreeBSD.org> writes:
>
> > This permits these registers to be used with non-Linux targets.
>
> Some GDBserver uses these target description files, like
> x86_64-*-mingw*, after this change, GDBserver will reply GDB the target
> description including "64bit-segments.xml". Then, GDB will request the
> contents of 64bit-segments.xml from GDBserver, looks 64bit-segments.xml
> is already builtin in GDBserver, so there isn't an issue here.
>
> The patch is good to me.
>
> P.S. this is a good example to show the inflexibility in current target
> description. After we change it to my new approach of target
> description, this change will be just two or three lines :)
Agreed. :) The combinatorics with XSAVE on x86 is especially bad.
--
John Baldwin