This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: File name convention ARCH-OSABI-tdep.c
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, gdb-patches at sourceware dot org
- Cc: weimin dot pan at oracle dot com
- Date: Tue, 27 Jun 2017 14:17:06 +0100
- Subject: Re: File name convention ARCH-OSABI-tdep.c
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C712BC04B946
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C712BC04B946
- References: <868tklhct8.fsf@gmail.com>
On 06/21/2017 11:09 AM, Yao Qi wrote:
>
> Hi,
> I want to extend the *-tdep.c file name convention. The current
> convention is ARCH-OSABI-tdep.c, and I want to extend it to
> ARCH-OSABI-tdep-FUNC.c, in which FUNC is about a certain functionality
> or feature about this target.
>
> The sparc64 adi patch
> (https://sourceware.org/ml/gdb-patches/2017-06/msg00472.html) adds a new
> file sparc64-adi-tdep.c which should be merged to sparc64-tdep.c
> according to the current naming convention. However, I think it is good
> to put different things in different files. So with the new convention
> proposed here, the new file can be sparc64-tdep-adi.c.
>
> Secondly, some *-tdep.c files are already quite large, arm-tdep.c is of
> 399434 bytes, 13318 lines. It is the 5th largest file. arm-tdep.c
> includes many things which are not related to each, like displaced
> stepping and process record. I am thinking that we should allow people
> moving them out of *-tdep.c to *-tdep-displaced.c and *-tdep-precord.c.
>
This is fine with me. I definitely agree with splitting big files in
smaller pieces.
Thanks,
Pedro Alves