This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Remove MAX_REGISTER_SIZE from remote-sim.c
- From: Alan Hayward <Alan dot Hayward at arm dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "vapier at gentoo dot org" <vapier at gentoo dot org>, nd <nd at arm dot com>
- Date: Tue, 27 Jun 2017 12:14:29 +0000
- Subject: Re: [PATCH] Remove MAX_REGISTER_SIZE from remote-sim.c
- Authentication-results: sourceware.org; auth=none
- Authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
- Nodisclaimer: True
- References: <E66B5C1B-FDC4-4A3F-937B-7A138DAFE01E@arm.com> <86wpbft0r4.fsf@gmail.com> <E7F813B0-BCB9-464C-BD4C-95F0A3D789E1@arm.com> <CAH=s-POSw=RatBGkLmryoAR4eN880nzxW+zt-p_TOuPMq8RRaw@mail.gmail.com> <692B46FA-E9FE-48BF-BE1C-9DDD606474B7@arm.com> <86fuelg0k1.fsf@gmail.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
> On 27 Jun 2017, at 11:57, Yao Qi <qiyaoltc@gmail.com> wrote:
>
> Alan Hayward <Alan.Hayward@arm.com> writes:
>
> Patch is good to me.
>
>> if (nr_bytes > 0
>> - && nr_bytes != register_size (gdbarch, regno) && warn_user)
>> + && nr_bytes != regsize && warn_user)
>> {
>
> A nit, can you put them in a single line?
>
> --
> Yao (齐尧)
Pushed with the above IF on a single line.
Alan.