This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v5] C++ify gdb/common/environ.c
- From: Pedro Alves <palves at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>, Simon Marchi <simon dot marchi at polymtl dot ca>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Mon, 19 Jun 2017 14:40:17 +0100
- Subject: Re: [PATCH v5] C++ify gdb/common/environ.c
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8299F85365
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8299F85365
- References: <20170413040455.23996-1-sergiodj@redhat.com> <20170616222315.12779-1-sergiodj@redhat.com> <4e43c71a2ac4aa229bb262e18dec668c@polymtl.ca> <87tw3cy5h7.fsf@redhat.com>
On 06/19/2017 05:19 AM, Sergio Durigan Junior wrote:
> I
> think it also makes a lot more sense to always initialize the vector
> with a NULL element, because this means we're correctly dealing with the
> case where there's no environment variable to be passed to the inferior.
This sentence confuses me, because I don't understand what you mean
by "correctly" here. What was incorrect?
Thanks,
Pedro Alves