This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] LONGEST and ULONGEST function template instantiation
- From: Alan Hayward <Alan dot Hayward at arm dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, nd <nd at arm dot com>
- Date: Wed, 14 Jun 2017 13:54:31 +0000
- Subject: Re: [RFC] LONGEST and ULONGEST function template instantiation
- Authentication-results: sourceware.org; auth=none
- Authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com;
- Nodisclaimer: True
- References: <1497353362-14441-1-git-send-email-yao.qi@linaro.org> <CAH=s-PPP7v1QTSD7Tg-DbVHWr0Egp18KN4XWu=CjTBBMDO9dOg@mail.gmail.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
> On 13 Jun 2017, at 12:33, Yao Qi <qiyaoltc@gmail.com> wrote:
>
> On Tue, Jun 13, 2017 at 12:29 PM, Yao Qi <qiyaoltc@gmail.com> wrote:
>
>>
>> This patch was posted here
>> https://sourceware.org/ml/gdb-patches/2017-05/msg00492.html but the
>> problem was fixed in a different way. However, I think the patch is still
>> useful to shorten the code.
>
> Add Alan to CC.
>
> It is an RFC, because I am not sure people like it or hate it :)
My only objection to this would be that “enable_if” is fairly confusing.
However, having said that, I think the end result is quite nice, and
calling the functions is very simple, so I withdraw my objection.
It would be nice if the header files could use “LongType” instead of
the longer “enable_if” block, however I remember when I tried this
myself and couldn’t find a way around it.
Alan.