This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [binutils patch] DWARF-5: readelf: .debug_names
- From: Nick Clifton <nickc at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>, binutils at sourceware dot org
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 6 Jun 2017 14:41:15 +0100
- Subject: Re: [binutils patch] DWARF-5: readelf: .debug_names
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=nickc at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com CDA04C04B31F
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CDA04C04B31F
- References: <20170526181552.GA15442@host1.jankratochvil.net>
Hi Jan,
> binutils/ChangeLog
> 2017-05-26 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * dwarf.c: Include assert.h.
> (MAX, MIN, get_IDX_name, display_debug_names): New.
> (debug_displays): Add .debug_names.
> * dwarf.h: (enum dwarf_section_display_enum): Add debug_names.
> * readelf.c (process_section_headers): Add ".debug_names".
Approved - please apply.
Note:
> + printf (_("Version %ld\n"), (long) dwarf_version);
> + if (dwarf_version != 5)
Shouldn't this test be for >= 5 ?
Cheers
Nick