This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/3] C++ify breakpoint class hierarchy (destructors only)

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Pedro Alves <palves at redhat dot com>
Cc: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
Date: Fri, 02 Jun 2017 21:20:11 +0200
Subject: Re: [PATCH 3/3] C++ify breakpoint class hierarchy (destructors only)
Authentication-results: sourceware.org; auth=none
References: <1496345650-11832-1-git-send-email-simon.marchi@ericsson.com> <1496345650-11832-3-git-send-email-simon.marchi@ericsson.com> <4db67d4b-2215-bad2-e286-d9f01d27a07e@redhat.com>

On 2017-06-02 18:59, Pedro Alves wrote:

LGTM, all three patches.

Maybe mark dtors with "override"?

Thanks,
Pedro Alves

Oh, I didn't know destructors could have this keyword. From what I cansee, it makes sure the base classes have virtual destructors, cool.I'll add that.

References:
- [PATCH 1/3] Introduce and use new_breakpoint_from_type
  - From: Simon Marchi
- [PATCH 3/3] C++ify breakpoint class hierarchy (destructors only)
  - From: Simon Marchi
- Re: [PATCH 3/3] C++ify breakpoint class hierarchy (destructors only)
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]